Merge pull request #37 from gravity-ui/fix-duplicate-suggested-presets

fix: not duplicate suggested presets
gravity-ui · Oct 4, 2023 · 9a42c1f · 9a42c1f
2 parents f72a946 + cb33543
commit 9a42c1f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/controller.ts b/src/controller.ts
@@ -360,7 +360,10 @@ export class Controller<HintParams, Presets extends string, Steps extends string
         }
 
         this.state.base.activePresets.push(presetSlug);
-        this.state.base.suggestedPresets.push(presetSlug);
+
+        if (!this.state.base.suggestedPresets.includes(presetSlug)) {
+            this.state.base.suggestedPresets.push(presetSlug);
+        }
 
         this.hintStore.closeHint();
 

diff --git a/src/tests/presets.test.ts b/src/tests/presets.test.ts
@@ -69,12 +69,14 @@ describe('preset management', function () {
         it('run same preset -> not duplicate', async function () {
             const controller = new Controller(options);
             await controller.runPreset('createQueue');
+            await controller.finishPreset('createQueue');
             await controller.runPreset('createQueue');
 
             const newState =
                 options.onSave.state.mock.calls[options.onSave.state.mock.calls.length - 1][0];
 
             expect(newState.activePresets).toEqual(['createProject', 'createQueue']);
+            expect(newState.suggestedPresets).toEqual(['createProject', 'createQueue']);
         });
 
         it('preset not from config -> nothing', async function () {