Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Commit

Permalink
Do not set priorityClassName for hooks (#2066)
Browse files Browse the repository at this point in the history
Reverting previous changes for hooks. cluster-critical priority could
be set only for kube-system resources and this could break existing
pre-update hooks for applications.
  • Loading branch information
Sergei Antipov authored Aug 27, 2020
1 parent f4ae2c6 commit 87cfb76
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
5 changes: 0 additions & 5 deletions lib/app/hooks/configure.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@ func configureMetadata(job *batchv1.Job, p Params) error {
job.Spec.Template.Spec.SecurityContext = defaults.HookSecurityContext()
}

// if priorityClassName is not specified, set the default one
if job.Spec.Template.Spec.PriorityClassName == "" {
job.Spec.Template.Spec.PriorityClassName = defaults.HookPriorityClassName
}

return nil
}

Expand Down
3 changes: 0 additions & 3 deletions lib/defaults/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -1182,9 +1182,6 @@ const (

// GravityFileLabel specifies the file label for the gravity binary
GravityFileLabel = "system_u:object_r:gravity_exec_t:s0"

// HookPriorityClassName specifies the default priority class for hooks
HookPriorityClassName = "system-cluster-critical"
)

var (
Expand Down

0 comments on commit 87cfb76

Please sign in to comment.