Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto and Manual deployment management modes #769

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Auto and Manual deployment management modes #769

merged 1 commit into from
Sep 6, 2023

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Sep 6, 2023 •
edited
Loading

Resolves #713

@tilacog tilacog linked an issue Sep 6, 2023 that may be closed by this pull request
Add a deployment management mode configuration similar to allocation management mode #713
Closed
2 tasks
@tilacog tilacog requested a review from fordN September 6, 2023 18:08
fordN
fordN reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Just a question about how we parse the yarg.

packages/indexer-common/src/types.ts Show resolved Hide resolved
fordN
fordN approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tilacog tilacog force-pushed the 713-add-a-deployment-management-mode-configuration-similar-to-allocation-management-mode branch from d9e97b7 to a5c8413 Compare September 6, 2023 18:40
@tilacog tilacog merged commit 61e3194 into main Sep 6, 2023
8 checks passed
@tilacog tilacog deleted the 713-add-a-deployment-management-mode-configuration-similar-to-allocation-management-mode branch September 6, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordN fordN fordN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a deployment management mode configuration similar to allocation management mode
2 participants
@tilacog @fordN