*: Add support for local querying of Epoch and TAP subgraphs #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For user, this change effectively adds support for local querying on epoch and tap subgraphs (previously only supported on network subgraph). - For contributors, this simplifies the codebase to have 1 SubgraphClient class instead of 3 separate implementations: EpochSubgraph, NetworkSubgraph and TapSubgraph.
fordN
changed the title
fordN
force-pushed
the
ford/merge-subgraph-clients
branch
from
e9f0894 to
9e514a9
Compare
|
Looks pretty good, I love the idea of having one more generalized class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EpochSubgraph,NetworkSubgraph, andTAPSubgraphclass implementations into a single, more generalized class:SubgraphClient. By doing so support for local deployment querying is added for Epoch and TAP subgraphs.Background
The goal here is to add support for querying local deployments of the Epoch and TAP subgraphs. Instead of updating the EpochSubgraph and TAPSubgraph classes to that effect I merged those in with the NetworkSubgraph class which already has local querying support and auto switching between local and external based on health of endpoints.