fix: add pagination to tap collector #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
672fb65 to
a65e5e1
Compare
|
Looks good but Id like seeing some sort of test or let us know if any test was done on your side for this |
@gusinacio was this addressed? |
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
a65e5e1 to
f7ac107
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
f7ac107 to
d178552
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
27916bd to
8992552
Compare
|
Hello @dwerner and @carlosvdr. I just tested everything. Could you review again? |
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
8992552 to
0c6589b
Compare
carlosvdr
approved these changes
Oct 10, 2024
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/pagination-for-retry-logic
branch
from
560c035 to
4311115
Compare
dwerner
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Depends on #1012