fixed IsPublicApiEnabled and related test

grantwinney · Feb 19, 2018 · 072a91f · 072a91f
1 parent a921333
commit 072a91f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/GhostSharp/GhostAPI.cs b/GhostSharp/GhostAPI.cs
@@ -95,13 +95,20 @@ public bool IsPublicApiEnabled(string clientId = null, string clientSecret = nul
 
             try
             {
-                // todo: this /should/ work if suppressing exceptions - need test
-                return GetUsers(new UserQueryParams { Limit = 1, Fields = "id" }) != null;
+                return GetUsers(new UserQueryParams { Limit = 1, Fields = "id" }).Users != null;
             }
             catch (GhostSharpException)
             {
+                if (SuppressionLevel == SuppressionLevel.None)
+                    throw;
                 return false;
             }
+            catch (Exception)
+            {
+                if (SuppressionLevel == SuppressionLevel.All)
+                    return false;
+                throw;
+            }
         }
 
         /// <summary>

diff --git a/GhostSharpTests/CreatePostTests.cs b/GhostSharpTests/CreatePostTests.cs
@@ -26,8 +26,6 @@ public CreatePostTests()
         [Fact]
         public void CreatePost_ReturnsPost_WhenPostCreated()
         {
-            // todo: need to figure out why most fields aren't showing in post
-
             createdPost = auth.CreatePost(GeneratePost());
 
             Assert.Equal(title, createdPost.Title);

diff --git a/GhostSharpTests/GET_AUTH_TOKEN.cs b/GhostSharpTests/GET_AUTH_TOKEN.cs
@@ -1,5 +1,6 @@
 using System;
 using GhostSharp;
+using GhostSharp.Entities;
 using Xunit;
 
 namespace GhostSharpTests
@@ -21,9 +22,12 @@ public void GetYourVeryOwnAuthToken()
         [Fact]
         public void IsPublicApiEnabled_ReturnsCorrectValue()
         {
-            var auth = new GhostAPI(Url, ClientId, ClientSecret);
-
-            // Try disabling the API on your site and change this to Assert.False
+            var auth = new GhostAPI(Url, ClientId, ClientSecret)
+            {
+                SuppressionLevel = SuppressionLevel.GhostOnly
+            };
+
+            // Try disabling the API on your site and change this to Assert.False
             Assert.True(auth.IsPublicApiEnabled());
         }
     }