Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cache_tag_rowid to a partial index because we don't need to query rows efficiently where tag IS NULL #307

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Change Cache_tag_rowid to a partial index because we don't need to query rows efficiently where tag IS NULL #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7509e5a
Change `Cache_tag_rowid` to a partial index because we don't need to …
ddorian Feb 27, 2024
db6492e
Fix formatting
ddorian Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion diskcache/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,10 @@ def create_tag_index(self):

"""
sql = self._sql
sql('CREATE INDEX IF NOT EXISTS Cache_tag_rowid ON Cache(tag, rowid)')
sql(
'CREATE INDEX IF NOT EXISTS Cache_tag_rowid ON Cache(tag, rowid) '
'WHERE tag IS NOT NULL'
)
self.reset('tag_index', 1)

def drop_tag_index(self):
Expand Down
Loading