Update the query only branch. #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a Deque, a transaction was used to extend elements from the
given iterable. The transaction is not used in Index.__init__ or in the
FanoutCache.fromcache API.
Users that want Deque.__init__ to use a transaction as before should use:
d = Deque()
with d.transact():
d.extend(iterable)
The transaction is therefore explicit and consistent with other APIs.
* Add maxlen parameter to diskcache.Deque
…nks#288) Error caused by copy/paste from pull().
Signed-off-by: Andrea Odetti <[email protected]>
Signed-off-by: Andrea Odetti <[email protected]>
|
It is probably more interesting to look at this |
Signed-off-by: Andrea Odetti <[email protected]>
Signed-off-by: Andrea Odetti <[email protected]>
Signed-off-by: Andrea Odetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the query-only branch.
#113