This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my initial attempt to convert gramps to TypeScript.
Some notes:
TypeScript interfaces don't need to be implemented so the following is valid:
Interface files are not output during compilation and there is no executable code in files that just export interfaces so I'm using a naming convention to differentiate interface files to exclude them from coverage reporting. If we ever need to make a file that fits this naming convention (interface files are prefixed with a capital 'I') and is not an interface file then we may need to change how these files are excluded. They need to be excluded since coverage is reported as 0% statement coverage.
This implementation uses some loose definitions to fit the existing code. Implicit "any" type is not allowed; however, there is a lot of use of explicit any that could be more strictly defined. Most of the inputs and outputs are defined via interfaces to improve usability.