Merge pull request #116 from grafana/feature/description-cleanup

fix: remove redundant IP address from description
grafana · Dec 18, 2023 · 6a4cbea · 6a4cbea
2 parents 6e18fb7 + 757569f
commit 6a4cbea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dashboard/extension.go b/dashboard/extension.go
@@ -86,7 +86,7 @@ func (ext *extension) Description() string {
 		return ext.name
 	}
 
-	return fmt.Sprintf("%s (%s) %s", ext.name, ext.options.addr(), ext.options.url())
+	return fmt.Sprintf("%s %s", ext.name, ext.options.url())
 }
 
 // SetThresholds saves thresholds provided by k6 runtime.

diff --git a/dashboard/extension_test.go b/dashboard/extension_test.go
@@ -35,7 +35,7 @@ func TestNewExtension(t *testing.T) {
 	assert.NoError(t, err)
 	assert.NotNil(t, ext)
 
-	assert.Equal(t, "dashboard (localhost:1) http://localhost:1", ext.Description())
+	assert.Equal(t, "dashboard http://localhost:1", ext.Description())
 
 	params.ConfigArgument = "period=2"
 
@@ -179,7 +179,7 @@ func TestExtension_random_port(t *testing.T) {
 
 	assert.Equal(
 		t,
-		fmt.Sprintf("foo (%s) %s", dashboard.options.addr(), dashboard.options.url()),
+		fmt.Sprintf("foo %s", dashboard.options.url()),
 		ext.Description(),
 	)