-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding minimum value filtering and dual metric, using circle sizes and colours for different metrics. #327
base: master
Are you sure you want to change the base?
Conversation
Dear Eduardo, this patch is very valuable. Thanks a stack for sharing it with the community. For your records, Grafana Labs will probably move on to integrate the new "Geomap panel" into Grafana core, as outlined by @ryantxu at grafana-toolbox#108. However, we are still maintaining the canonical friendly fork of the original Worldmap panel on behalf of the Panodata Map Panel and would appreciate your contribution very much. @daquinoaldo was so nice to submit #322 from his pen as grafana-toolbox#117 just recently. Maybe you would like to join him on this? With kind regards, P.S.: Some feedback/questions to the features this patch is adding to the code base. JFYI, I don't expect any answers if you don't feel like those pointers are related at all.
Is this similar/related to the request at grafana-toolbox#94 by @manupomax or even grafana-toolbox#60 by @Dulanic?
Is this what @edornd requested at grafana-toolbox#71 (comment)? Please also note grafana-toolbox#64 by @JonasProgrammer, which probably touches a similar space. |
Dear Andreas, First, thanks for the kindness and attention, it's always a pleasure to deal with kind people such yourself! Here are my answers:
No. Unfortunately, the filter only filters any metric under the defined unit. If you don't want to see circles where the value are <10, that will do it. Won't deal with percentages or thresholds.
Yes. Yes and yes. This splits up colour and diameter as two separate metrics and would solve those requests. About the PR in general, I'm using this panel in a project and it would be amazing to have those functionalities coming directly from the official plugin. I discussed with my colleagues about the panomap and to shift to it now would bring us some trouble that we're not able to handle right now. We're excited to know that this amazing tool is going to be in grafana's Core and we would love to collaborate so those functionalities would be available when it comes. Let me know how can I contribute more and what should I do to see this merged, if possible. Thanks! :D |
Adding two new functionalities:
Filtering data points with value lower than a number, set up on the editor screen.
Using colour as a second metric, enabling the map to show two different metrics, like total bought pizzas and complaints, or sessions and errors.