Update Basemaps URL and attributions #280
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates basemaps URL to the new CDN URL and fixes the attributions to match current requirements. It also changes our old name from
CartoDB
toCARTO
(although looks that basemaps names are internal and not exposed to the user, we could skip this if has any kind of side-effects on existing basemaps and just change URL and Attributions).Full context
We've recently changed our CDN (last week) and we have a plan mid-long term (depends on how quick we manage to stop all the traffic there) to deprecate our
.global.ssl.fastly.net
domains.Reviewing the history of this project at some point it used the
*.basemaps.cartocdn.com
endpoints but were changed because of the lack of HTTPS, which is not an issue anymore.Additional stuff
Just as a suggestion I'd add to the attributions
<a>
propertiestarget="_blank" rel="noopener"
, this way if a user clicks on it doesn't close the Grafana dashboard but opens it in a new tab.