Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OnCall client setup to support service account auth #1859

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update OnCall client setup to support service account auth #1859

wants to merge 1 commit into from

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Oct 25, 2024 •
edited
Loading

Related to https://github.com/grafana/oncall-private/issues/2826

Requires grafana/amixr-api-go-client#24 (and a client release + updating dep here)

@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@matiasb matiasb mentioned this pull request Oct 25, 2024
Draft
@matiasb matiasb force-pushed the matiasb/oncall-service-account-support branch 2 times, most recently from 9f8ea6d to 208e9eb Compare November 15, 2024 12:42
@matiasb matiasb force-pushed the matiasb/oncall-service-account-support branch from 208e9eb to 886067f Compare November 15, 2024 13:11
@matiasb matiasb changed the title WIP Update OnCall client setup to support service account auth Nov 15, 2024
@matiasb matiasb mentioned this pull request Nov 15, 2024
Open
joeyorlando
joeyorlando approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM. Should we update the provider documentation on service account vs oncall api token auth here? Do you think this warrants a major-version bump of the provider?

@matiasb
Copy link
Contributor Author

matiasb commented Nov 20, 2024

overall LGTM. Should we update the provider documentation on service account vs oncall api token auth here? Do you think this warrants a major-version bump of the provider?

Yeah, I will be updating some docs here before merging (still need to release the updated API client and push some changes here, besides I want to do some additional testing too). About the provider version, not sure who/how that is decided (in any case we are not breaking any compatibility just extending the auth support).

Also I would like to update some other docs I found re OnCall and Terraform once I confirm everything working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @joeyorlando