Secrets consistency for the chart

[ksa-real]

• Enabling existing secrets for external MySQL and Redis
• Tolerate existing secrets for bundled charts.
• README.md: secrets handling explained.
• Fixed multiple bugs where missing required field was replaced with default instead of failing.
• PHONE_NOTIFICATIONS_LIMIT was on the wrong level: it was not set if existingSecret was true.

Next are the cosmetic changes. They improve chart consistency, e.g. prevent generation of multiple new lines in certain cases:

• Common approach to spaces trimming. This typically allows curly blocks and actual strings indentation and nice nindent usage:

  • Two curly blocks should not trim the same space. I.e. "{{ ... -}} {{- ... }}" shouldn't happen.

  • Template generates either single line or multiline string. In both cases, no new line appears on both sides of the output string. So we delete unnecessary new lines inside and at the end of string with "trim-to-left" ({{- ) and the leading new line using "trim-to-right" (-}}).
    Note that trimming both leading and trailing new line is not always easily possible: Function similar to nindent but ignoring content's initial new line. Masterminds/sprig#357

    Example.

    {{- define "mytemplate" -}}
    {{ if someBoolean -}}
      {{ .Value.some }}
    {{- else -}}
      some string
    {{- end }}
    {{- end }}
    

• template replaced with include. It is often recommended to use include by default, as it allows pipelining.

Checklist

• Tests updated - No tests for Helm chart
• Documentation added
• CHANGELOG.md updated

[matiasb]

At first sight, suggestions make sense to me. @iskhakov, would you take a look?

[ksa-real]

@iskhakov Friendly ping

[marcusteixeira]

Ac

[ksa-real]

Can someone take a look, please?

[ksa-real]

Ac

Is it a common abbreviation? I wonder what it means in this context :)

[ksa-real]

@Matvey-Kuk @iskhakov Can you please assign this to someone?

[ksa-real]

Closed accidentally by pushing a version with incomplete rebase

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[iskhakov]

waiting for changes to pass tests

[ksa-real]

I have doubts about TWILIO_ACCOUNT_SID. IMO it should reside in existingSecret if such exists (as being a part of credentials).

[ksa-real]

@iskhakov Can you please approve the workflows? Note, that due to a single file accidental change (despite the later reversal) a bunch of unnecessary tests were triggered. Not sure if it is possible to remove them, or we should just run the unnecessary tests.

[ksa-real]

@iskhakov Please, re-approve the workflows

[ksa-real]

I've fixed the tests. Everything seems to run fine in my forked workflow, except for e2e tests which are slow to be picked up by workers: workflow