Helm: add commonLabels #9742
Open
Helm: add commonLabels #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fabio trigari <[email protected]>
|
|
…na#9067) Signed-off-by: fabio trigari <[email protected]>
… bucket job (grafana#9067) Signed-off-by: fabio trigari <[email protected]>
|
Hello @ftrigari . Thanks a lot for your contribution ! The proposed change looks good overall and makes sense. However, I noticed that the lint-helm check is currently failing. It seems this is due to the change introducing an empty line when no labels are provided. Could you please address this issue to ensure the lint-helm check passes? |
Signed-off-by: fabio trigari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Every object created by the chart could have custom labels.
Which issue(s) this PR fixes or relates to
Fixes #9067
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.