[r313] MQE: subqueries #9684
Merged
[r313] MQE: subqueries #9684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable upstream tests * Add benchmark * Introduce feature toggle * Don't assume all operators are running at the top level of a query * Add ability to reuse an existing point slice for a ring buffer * Add `Release` method to ring buffers * Introduce range query tests * Bring in TestSubquerySelector from Prometheus * Change `RangeVectorOperator.NextStepSamples` to return ring buffers rather than receive them * Refactor `TestSubqueries` * Initial (largely working) implementation * Fix handling of @ * Enable newly supported upstream test cases * Add further benchmark * Add changelog entry * Address PR feedback: clarify comments Co-authored-by: Joshua Hesketh <[email protected]> * Add tests for ring buffer `Release` implementations * Address PR feedback: update comment to match new behaviour * Address PR feedback: fix indentation * Expand native histogram tests * Add test for deeply nested subqueries with changing step. * Run test cases in TestSubqueries against Prometheus' engine too. --------- Co-authored-by: Joshua Hesketh <[email protected]> (cherry picked from commit 3031f23)
charleskorn
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3031f23 from #9664