helm: fix broken topology spread constraints in metamonitoring's GrafanaAgent #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
force-pushed
the
vldmr/helm-grafana-agent-topology-spread
branch
from
4665ef5 to
647f69c
Compare
56quarters
approved these changes
Oct 18, 2024
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/helm-grafana-agent-topology-spread
branch
from
647f69c to
47b1e54
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9669-to-mimir-distributed-release-5.5 origin/mimir-distributed-release-5.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0d3f52f74245d6ee1e20e5a6b8453000108b6543
# Push it to GitHub
git push --set-upstream origin backport-9669-to-mimir-distributed-release-5.5
git switch main
# Remove the local backport branch
git branch -D backport-9669-to-mimir-distributed-release-5.5Then, create a pull request where the |
narqo
added a commit
that referenced
this pull request
Oct 18, 2024
…anaAgent (#9669) * helm: fix indentation in metamonitoring's topologySpreadConstraints * rebuild assets * update CHANGELOG Signed-off-by: Vladimir Varankin <[email protected]> (cherry picked from commit 0d3f52f)
narqo
added a commit
that referenced
this pull request
Oct 18, 2024
…anaAgent (#9669) * helm: fix indentation in metamonitoring's topologySpreadConstraints * rebuild assets * update CHANGELOG (cherry picked from commit 0d3f52f) Signed-off-by: Vladimir Varankin <[email protected]>
narqo
added a commit
that referenced
this pull request
Oct 18, 2024
…anaAgent (#9669) (#9670) * helm: fix indentation in metamonitoring's topologySpreadConstraints * rebuild assets * update CHANGELOG (cherry picked from commit 0d3f52f) Signed-off-by: Vladimir Varankin <[email protected]>
narqo
added a commit
that referenced
this pull request
Oct 21, 2024
* fix: add mimir upgrade in the changelog (#9621) (#9623) * fix: add mimir upgrade in the changelog This PR fixes the changelog by setting the correct memcached version and add the changelog for mimir 2.14.0 * Update operations/helm/charts/mimir-distributed/CHANGELOG.md --------- Co-authored-by: Vladimir Varankin <[email protected]> (cherry picked from commit 4a73545) Co-authored-by: Quentin Bisson <[email protected]> * helm: fix broken topology spread constraints in metamonitoring's GrafanaAgent (#9669) (#9670) * helm: fix indentation in metamonitoring's topologySpreadConstraints * rebuild assets * update CHANGELOG (cherry picked from commit 0d3f52f) Signed-off-by: Vladimir Varankin <[email protected]> * helm: prepare release 5.5.1 (#9676) * helm: bump patch version Signed-off-by: Vladimir Varankin <[email protected]> * rebuild assets Signed-off-by: Vladimir Varankin <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> Co-authored-by: Grot (@grafanabot) <[email protected]> Co-authored-by: Quentin Bisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a broken indentation in the
topologySpreadConstraintsinside theGrafanaAgentCRD, introduced in #8670. The CRD's specification is defined here. It requires the field to be the direct child of thespecfield.Which issue(s) this PR fixes or relates to
Fixes #9638
Notes: this needs to be backported to the 5.5 release branch.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.