kafka replay speed: rename existing cortex_ingest_storage_reader_records_* metrics #9654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds_* metrics Because of the batching behaviour of the sharding pushers, there is no longer a 1:1 matching between the kafka records and the errors we get from the TSDB. Because of this, the existing metrics `cortex_ingest_storage_reader_records_failed_total` and `cortex_ingest_storage_reader_records_total` no longer make sense. This PR renames them to `cortex_ingest_storage_reader_requests_total` and `cortex_ingest_storage_reader_requests_failed_total` while keeping the alerts and dashboards working. It also fixes a bug in how `requests_total` is tracked - it used to be only tracked when there is an error. Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
pracucci
approved these changes
Oct 17, 2024
Co-authored-by: Marco Pracucci <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
deleted the
dimitar/ingest/replay-speed/fix-records-metrics
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Because of the batching behaviour of the sharding pushers, there is no longer a 1:1 matching between the kafka records and the errors we get from the TSDB. Because of this, the existing metrics
cortex_ingest_storage_reader_records_failed_totalandcortex_ingest_storage_reader_records_totalno longer make sense.This PR renames them to
cortex_ingest_storage_reader_requests_totalandcortex_ingest_storage_reader_requests_failed_totalwhile keeping the alerts and dashboards working. It also fixes a bug in howrequests_totalis tracked - it used to be only tracked when there is an error.Which issue(s) this PR fixes or relates to
the change with sharding was introduced in #9454
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.