Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #9612

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Update release instructions #9612

merged 2 commits into from
Oct 14, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Oct 14, 2024

What this PR does

I've noticed a couple of points, that were not obvious in the release process. This PR updates the instructions, adding those for future release engineers.

  1. Add a reminder on how to merge the release branch back into main.
  2. Add a reminder to update the Helm chart's changelog during final release.
  3. Fix typos.

Which issue(s) this PR fixes or relates to

Relates to #9382

@narqo narqo requested a review from a team as a code owner October 14, 2024 10:35
@narqo narqo force-pushed the vldmr/release-notes branch from b720e82 to c69820a Compare October 14, 2024 10:39
@narqo narqo changed the title Update release notes Update release instructions Oct 14, 2024
Signed-off-by: Vladimir Varankin <[email protected]>
@narqo narqo force-pushed the vldmr/release-notes branch from c69820a to cc359c8 Compare October 14, 2024 12:24
Copy link
Contributor

@lamida lamida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave some feedback for little bit typo and suggestion.

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
operations/helm/charts/mimir-distributed/RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: Jon Kartago Lamida <[email protected]>
@narqo narqo enabled auto-merge (squash) October 14, 2024 14:28
@narqo narqo merged commit 3ceec52 into main Oct 14, 2024
31 checks passed
@narqo narqo deleted the vldmr/release-notes branch October 14, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants