MQE: introduce series metadata function type #9558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/mqe-functions
branch
from
d840e92 to
3a56b06
Compare
jhesketh
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR is a follow up to #9553.
It introduces a new type,
SeriesMetadataFunctionDefinition, which contains both the function itself as well as theNeedsSeriesDeduplicationflag.This should make it impossible in the future to forget to set
NeedsSeriesDeduplicationwhen usingDropSeriesName.I don't love that we have a
SeriesMetadataFunctionDefinitionand aSeriesMetadataFunctype now, open to other ideas for better names.Which issue(s) this PR fixes or relates to
#9553
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.