Jsonnet: Add support to deploy distributors in multi availability zones #9548
Conversation
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
added
the
sigyn
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
| multi_zone_distributor_enabled: true, | ||
| multi_zone_distributor_availability_zones: availabilityZones, | ||
|
|
||
| autoscaling_distributor_enabled: true, |
There was a problem hiding this comment.
Note to reviewers:
I have added autoscaling here in order to test autoscaling combined with multi-AZ, because we otherwise don't test it anywhere else.
There was a problem hiding this comment.
Can we create a copy of this file instead, and leave the original unmodified? This file is imported by many other files (eg. ones to show migration steps), but we don't want to change them all.
There was a problem hiding this comment.
we don't want to change them all
Why not? This is the base test used for multi-zone setups. Why not enabling distributor too?
There was a problem hiding this comment.
I see what you mean, it's just that this file is used as a base for our migration procedure to ingest-storage, and nobody is running with multi-zone distributors today.
There was a problem hiding this comment.
As discussed in a Slack thread, we decided to move distributor-related part in test-multi-zone-distributor.jsonnet.
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
What this PR does
This PR adds support to deploy distributors in multi availability zones.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.