Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingester: promote series limit using own series to stable #9496

Closed
wants to merge 3 commits into from

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Oct 2, 2024

What this PR does

This feature was introduced in #6718, and we have been running it enabled in Grafana Cloud since. I suggest we promote it to stable in the next release. What do you think @pstibrany @pr00se?

Which issue(s) this PR fixes or relates to

Relates to #9382 (as a post-2.14 clean up)

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

narqo added 2 commits October 2, 2024 14:07
Signed-off-by: Vladimir Varankin <[email protected]>
@narqo narqo requested review from tacole02 and a team as code owners October 2, 2024 12:14
Signed-off-by: Vladimir Varankin <[email protected]>
@narqo narqo force-pushed the vldmr/promote-series-limit-using-own-series branch from 5a44683 to 0f5c822 Compare October 2, 2024 12:14
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Perhaps we could remove the flags as well?

I'm also not sure if we have provided documentation for this feature.

Copy link
Contributor

@pr00se pr00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these still apply:

#8695 (comment)
#8695 (comment)

@narqo
Copy link
Contributor Author

narqo commented Oct 2, 2024

I think these still apply [..]

Thank you. I opened #9497 to add a code comment about this one. Otherwise, one day someone will merge it, without knowing this history 🙈

@narqo narqo closed this Oct 2, 2024
@narqo narqo deleted the vldmr/promote-series-limit-using-own-series branch October 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants