Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka replay speed: update fetch bytes estimation on multiple attempts #9493

Merged
merged 1 commit into from
Oct 2, 2024
Merged

kafka replay speed: update fetch bytes estimation on multiple attempts #9493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/storage/ingest/fetcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ func (r *concurrentFetchers) run(ctx context.Context, wants chan fetchWant, logg
}
// Next attempt will be from the last record onwards.
w.startOffset = f.Records[len(f.Records)-1].Offset + 1
w = w.UpdateBytesPerRecord(f.fetchedBytes, len(f.Records)) // This takes into account the previousFetch too. This should give us a better average than using just the records from the last attempt.

// We reset the backoff if we received any records whatsoever. A received record means _some_ success.
// We don't want to slow down until we hit a larger error.
Expand Down
Loading