-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deprecated features for 2.14 #9407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-grpc-method-limiter Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/mimir-214-cleanup-deprecated
branch
2 times, most recently
from
September 25, 2024 12:55
13a9ddb
to
87a9ead
Compare
pstibrany
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
vldmr/mimir-214-cleanup-deprecated
branch
from
September 25, 2024 13:57
87a9ead
to
634f3de
Compare
grafanabot
pushed a commit
that referenced
this pull request
Sep 26, 2024
* ingester, distributor: remove deprecated limit-inflight-requests-using-grpc-method-limiter Signed-off-by: Vladimir Varankin <[email protected]> * querier: remove deprecated -querier.max-query-into-future Signed-off-by: Vladimir Varankin <[email protected]> * update CHANGELOG Signed-off-by: Vladimir Varankin <[email protected]> * rebuild assets Signed-off-by: Vladimir Varankin <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> (cherry picked from commit 286c23c)
narqo
added a commit
that referenced
this pull request
Sep 26, 2024
* ingester, distributor: remove deprecated limit-inflight-requests-using-grpc-method-limiter Signed-off-by: Vladimir Varankin <[email protected]> * querier: remove deprecated -querier.max-query-into-future Signed-off-by: Vladimir Varankin <[email protected]> * update CHANGELOG Signed-off-by: Vladimir Varankin <[email protected]> * rebuild assets Signed-off-by: Vladimir Varankin <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]> (cherry picked from commit 286c23c) Co-authored-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the leftover flags that were deprecated in Mimir 2.12.
Note, I removed a feature per commit, to simplify the review.
Which issue(s) this PR fixes or relates to
Relates to #9382
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.