Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alertmanager: Skip exposing some more metrics when they have zero value #9359

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Alertmanager: Skip exposing some more metrics when they have zero value #9359

merged 13 commits into from
Sep 26, 2024

Conversation

titolins
Copy link
Contributor

@titolins titolins commented Sep 20, 2024 •
edited
Loading

Filter 0 value tenant metrics as they are unnecessary

Related PR's

@titolins titolins requested review from a team as code owners September 20, 2024 20:29
@titolins titolins changed the title filter 0 value counter Alerting: Filter 0 value counter Sep 20, 2024
@titolins titolins changed the title Alerting: Filter 0 value counter Alerting: Filter 0 value counters Sep 20, 2024
@titolins titolins changed the title Alerting: Filter 0 value counters Alerting: Filter AM 0 value counters Sep 20, 2024
@stevesg
Copy link
Contributor

stevesg commented Sep 20, 2024

Nice one, we should put an entry in the CHANGELOG.md.

@titolins titolins mentioned this pull request Sep 23, 2024
Closed
@stevesg stevesg changed the title Alerting: Filter AM 0 value counters Alertmanager: Skip exposing some more metrics when they have zero value Sep 24, 2024
@titolins titolins force-pushed the titolins/filter-am-zero-value-counters branch 2 times, most recently from 0311b9c to 25cb0a1 Compare September 24, 2024 11:02
@titolins titolins force-pushed the titolins/filter-am-zero-value-counters branch from b7e3101 to 5f17809 Compare September 24, 2024 11:26
stevesg
stevesg approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to me, good work on debugging the integration test.

pstibrany
pstibrany approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@titolins titolins requested a review from tacole02 as a code owner September 25, 2024 10:06
@titolins titolins force-pushed the titolins/filter-am-zero-value-counters branch from 2f0a79d to 54db10b Compare September 25, 2024 10:08
@stevesg stevesg merged commit 23e5ba9 into main Sep 26, 2024
29 checks passed
@stevesg stevesg deleted the titolins/filter-am-zero-value-counters branch September 26, 2024 07:53
@stevesg stevesg mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevesg stevesg stevesg approved these changes

@tacole02 tacole02 tacole02 approved these changes

@pstibrany pstibrany pstibrany approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@titolins @stevesg @pstibrany @tacole02