Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments on ingester ScaledObject. #9352

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Update comments on ingester ScaledObject. #9352

merged 1 commit into from
Sep 20, 2024

Conversation

pstibrany
Copy link
Member

What this PR does

Updates comments on ingester ScaledObject to match how HPA works. Previous comments were wrong.

Checklist

  • [na] Tests updated.
  • [na] Documentation added.
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na] about-versioning.md updated with experimental features.

@pstibrany pstibrany requested a review from a team as a code owner September 20, 2024 12:31
pracucci
pracucci approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pstibrany pstibrany enabled auto-merge (squash) September 20, 2024 12:42
@pstibrany pstibrany merged commit 5e15310 into main Sep 20, 2024
29 checks passed
@pstibrany pstibrany deleted the Update-comments-on-ingester-ScaledObject branch September 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstibrany @pracucci