-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query scheduler query component load verification #8189
Draft
francoposa
wants to merge
17
commits into
main
Choose a base branch
from
francoposa/query-scheduler-query-component-load-verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
query scheduler query component load verification #8189
francoposa
wants to merge
17
commits into
main
from
francoposa/query-scheduler-query-component-load-verification
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
changed the title
Francoposa/query scheduler query component load verification
query scheduler query component load verification
May 27, 2024
francoposa
changed the base branch from
main
to
francoposa/query-scheduler-query-component-load
May 27, 2024 22:44
francoposa
changed the base branch from
francoposa/query-scheduler-query-component-load
to
main
May 27, 2024 22:45
francoposa
force-pushed
the
francoposa/query-scheduler-query-component-load-verification
branch
from
May 27, 2024 22:51
14a1429
to
d69510d
Compare
francoposa
force-pushed
the
francoposa/query-scheduler-query-component-load-verification
branch
from
May 28, 2024 21:46
d69510d
to
60cd195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Branched off of #8132, uses the actual code going into main to do an updated version of this sketch branch.
The important bit is here: https://github.com/grafana/mimir/pull/8189/files#diff-fb3d6b36d3cd727e1dd2353fb86c0aee0bfaae1c900e0f005ab913620021d551R447-R464, and the sleep added in
pkg/storegateway/gateway.go
The rest of the diff is just making some private fields public for the purposes of this hacked-up demo.
Ran two instances of a query script against this setup with different parameters, one to hit ingesters only and one to hit store gateways only, to verify the behavior that ingester queries can continue being serviced when the store-gateways back up.
The query script will print the response code and error message if any, so you can see the ingester-only requests continue getting 200 OKs while the store-gateway queries will receive something like
Error querying Prometheus: Get "http://localhost:8007/prometheus/api/v1/query_range?query=up+offset+1h0m0s&start=2024-05-27T16:18:17Z&end=2024-05-27T19:18:17Z&step=1m": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
While running the mimir microservices mode docker compose you can grep the scheduler logs for
request dropped
.This is a rudimentary simulation because we dequeue the store-gateway request then drop it if the store gateway capacity utilization is past the threshold. We are not yet able to simulate leaving the request in the queue and picking a different one with the current code, though that will be upcoming.
As an extension, we also cannot yet simulate here coming back to dequeue the request for the component over the utilization threshold if no other options are found, so this demo will drop requests past the utilization threshold even if there's only requests for a single query component coming in.
Query script utilized:
Script args for ingester-only queries, which continue to be serviced:
-range-duration 5m -sleep-duration 1s
Script args for store-gateway-only queries, which get backed up then dropped:
-range-duration 3h -offset-duration 1h -sleep-duration 1s
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.