Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: add tooltip with all series on Queries dashboard #8179

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented May 24, 2024

Before

Screenshot 2024-05-24 at 13 05 41

After
Screenshot 2024-05-24 at 13 05 24

This PR also adds a utility to make this easier. I decided to not add a changelog entry because this is too minor of a change.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Before

After

This PR also adds a utility to make this easier.

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner May 24, 2024 11:06
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning things up as you did this as well!

@dimitarvdimitrov dimitarvdimitrov merged commit 74628a9 into main May 29, 2024
31 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/mixin/add-stacked-tooltip-on-some-queries-queries branch May 29, 2024 14:43
narqo pushed a commit to narqo/grafana-mimir that referenced this pull request Jun 6, 2024
* mixin: add tooltip with all series on Queries dashbaord

Before

After

This PR also adds a utility to make this easier.

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Don't overwrite options

Signed-off-by: Dimitar Dimitrov <[email protected]>

* Update tests

Signed-off-by: Dimitar Dimitrov <[email protected]>

---------

Signed-off-by: Dimitar Dimitrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants