mixin dashbaords: add support for ingest storage replication #8175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
changed the title
pstibrany
approved these changes
May 23, 2024
Comment on lines
+240
to
+253
| # Classic storage | ||
| sum by (%(groupByCluster)s, %(groupByLabels)s) (%(perIngesterQuery)s) | ||
| / on (%(groupByCluster)s) group_left() | ||
| max by (%(groupByCluster)s) (cortex_distributor_replication_factor{%(distributor)s}) | ||
| or on (%(groupByCluster)s) | ||
| # Ingest storage | ||
| sum by (%(groupByCluster)s, %(groupByLabels)s) ( | ||
| max by (ingester_id, %(groupByCluster)s, %(groupByLabels)s) ( | ||
| label_replace( | ||
| %(perIngesterQuery)s, | ||
| "ingester_id", "$1", "%(instance)s", ".*-([0-9]+)$" | ||
| ) | ||
| ) | ||
| ) |
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
deleted the
dimitar/mixin/replace-usages-of-distributor_replication_factor
branch
pracucci
reviewed
May 28, 2024
| sum by (%(groupByCluster)s, %(groupByLabels)s) (%(perIngesterQuery)s) | ||
| / on (%(groupByCluster)s) group_left() | ||
| max by (%(groupByCluster)s) (cortex_distributor_replication_factor{%(distributor)s}) | ||
| or on (%(groupByCluster)s) |
There was a problem hiding this comment.
I don't understand one thing: what is this on (%(groupByCluster)s) (in this line) used for?
Isn't the query we want something like:
(
# Classic storage
) or (
# Ingest storage
)
There was a problem hiding this comment.
yeah good point. I don't think the on clause does much. Both sides already have the same set of label names.
Opened #8211
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
…#8175) Signed-off-by: Dimitar Dimitrov <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Some panels in the dashboards rely on
cortex_distributor_replication_factor. This metric is not exported if running in ingest storage (#7809).This PR updates all queries in the mixin that were relaying on
cortex_distributor_replication_factor. If the replication factor metric isn't present now the queries fall back to the maximum of each partition for the metric in question (such ascortex_ingester_active_series).Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.