Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mixtool in mimir-build-image #8032

Merged
merged 4 commits into from
May 3, 2024

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented May 2, 2024

What this PR does

Peter suggested to update mixtool in this comment. In this PR I'm doing it. mixtool has become way more picky with the linter, so I've added many exclusions. I think all exclusions make sense, except panel-units-rule that should be fixed, but it's low priority and I don't have bandwidth to do it right now.

Note to reviewers:

  • Review changes with "hide whitespace" enabled

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <[email protected]>
Copy link
Contributor

github-actions bot commented May 2, 2024

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version grafana/mimir-build-image:pr8032-d6540935d8. This can take up to 1 hour.

@pracucci pracucci changed the title Configure linter exclusions Update mixtool in mimir-build-image May 3, 2024
Signed-off-by: Marco Pracucci <[email protected]>
Copy link
Contributor

github-actions bot commented May 3, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8032-d6540935d8 already exists.

Signed-off-by: Marco Pracucci <[email protected]>
Copy link
Contributor

github-actions bot commented May 3, 2024

Not building new version of mimir-build-image. This PR modifies mimir-build-image/Dockerfile, but the image grafana/mimir-build-image:pr8032-d6540935d8 already exists.

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of updating mixtool!

@pracucci pracucci marked this pull request as ready for review May 3, 2024 10:02
@pracucci pracucci requested review from wilfriedroset, vaxvms, bubu11e and a team as code owners May 3, 2024 10:02
@pracucci pracucci merged commit 04f1447 into main May 3, 2024
32 checks passed
@pracucci pracucci deleted the update-mixtool-in-mimir-build-image branch May 3, 2024 10:02
This was referenced Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants