Refactoring: introduce Distributor.sendWriteRequestToPartitions() and sendWriteRequestToIngesters() #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sendWriteRequestToIngesters() Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Apr 12, 2024
| @@ -7416,46 +7438,43 @@ func TestStartFinishRequest(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestSendMessageMetadata(t *testing.T) { | |||
There was a problem hiding this comment.
Note to reviewers: this was was directly calling Distributor.sendToIngester() which doesn't exist anymore. I've refactored the test to run like other tests, and then assert on the gRPC context when the mockIngester.Push() request is received.
pracucci
commented
Apr 12, 2024
| beforePushHook func(ctx context.Context, req *mimirpb.WriteRequest) (*mimirpb.WriteResponse, error, bool) | ||
| } | ||
|
|
||
| func (i *mockIngester) registerBeforePushHook(fn func(ctx context.Context, req *mimirpb.WriteRequest) (*mimirpb.WriteResponse, error, bool)) { |
There was a problem hiding this comment.
Note to reviewers: this will be also used by a new test that will be added by #7871.
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Apr 12, 2024
colega
approved these changes
Apr 12, 2024
|
I tripled checked it 🤞 |
pracucci
deleted the
refactoring-before-add-write-tee-support-in-distributor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR is a follow up of #7877.
I'm working to add support to tee writes both to ingesters and partitions, as part of the migration procedure to the new experimental ingest storage. The full implementation is in this PR: #7871
In this PR I'm proposing a send and last refactoring to make #7871 easier (and possibly safer) to review. My n. 1 goal is to not introduce any regression in the path writing to ingesters.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.