Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mixin conditionally load ingest storage alerts #7867

Conversation

jmichalek132
Copy link
Contributor

What this PR does

As discussed in the link PR comments this PR adds an option to not include experimental ingest-storage alerts.

Which issue(s) this PR fixes or relates to

Fixes

Follow up PR for #7702 (comment)

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jmichalek132 jmichalek132 requested a review from a team as a code owner April 10, 2024 08:37
@jmichalek132 jmichalek132 mentioned this pull request Apr 10, 2024
4 tasks
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany enabled auto-merge (squash) April 10, 2024 08:44
@pstibrany pstibrany merged commit 2d636db into grafana:main Apr 10, 2024
29 checks passed
@jmichalek132 jmichalek132 deleted the jm-chore-mixin-conditionally-load-ingest-storage-alerts branch April 10, 2024 08:55
pracucci added a commit that referenced this pull request Jun 25, 2024
Signed-off-by: Marco Pracucci <[email protected]>
pracucci added a commit that referenced this pull request Jun 25, 2024
Signed-off-by: Marco Pracucci <[email protected]>
pracucci added a commit that referenced this pull request Jun 25, 2024
* Add ingest storage auto-generated config doc and mention it in the CHANGELOG

Signed-off-by: Marco Pracucci <[email protected]>

* Mention it in experimental features list

Signed-off-by: Marco Pracucci <[email protected]>

* Addressed doc review comments

Signed-off-by: Marco Pracucci <[email protected]>

* Addressed more doc review comments

Signed-off-by: Marco Pracucci <[email protected]>

* Add PR #7867 to CHANGELOG

Signed-off-by: Marco Pracucci <[email protected]>

* Added ingest_storage doc block in auto-generated doc

Signed-off-by: Marco Pracucci <[email protected]>

---------

Signed-off-by: Marco Pracucci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants