[mimir-distributed-release-5.3] helm: clarify keda docs #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* helm: clarify keda docs The per-component docs were wrong in that the metrics aren't always read from the metamonitoring prometheus. THis used to be the case when autoscaling was first implemented but since then kedaAutoscaling.prometheusAddress has been added. Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix typo Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit f842406)
grafanabot
requested review from
dimitarvdimitrov
and removed request for
a team
dimitarvdimitrov
approved these changes
Apr 8, 2024
dimitarvdimitrov
merged commit 6e8302c
into
mimir-distributed-release-5.3
32 checks passed
dimitarvdimitrov
deleted the
backport-7833-to-mimir-distributed-release-5.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f842406 from #7833