Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: prep 5.3.0-rc.0 and release notes template and docs #7818

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

krajorama
Copy link
Contributor

What this PR does

Step 5 in
https://github.com/grafana/mimir/blob/main/operations/helm/charts/mimir-distributed/RELEASE.md

Which issue(s) this PR fixes or relates to

N/A

Checklist

N/A

@krajorama krajorama added the helm label Apr 5, 2024
@krajorama krajorama requested review from jdbaldry and a team as code owners April 5, 2024 09:40
@krajorama krajorama marked this pull request as draft April 5, 2024 09:40
Signed-off-by: György Krajcsovits <[email protected]>
@krajorama krajorama marked this pull request as ready for review April 8, 2024 07:47
Copy link
Contributor

@flxbk flxbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama merged commit 218667d into mimir-distributed-release-5.3 Apr 8, 2024
31 checks passed
@krajorama krajorama deleted the krajo/fix branch April 8, 2024 08:21

Grafana Labs is excited to announce version 5.3 of the Grafana Mimir Helm chart, which is compatible with Grafana Mimir v2.12 or Grafana Enterprise Metrics (GEM) v2.12. The `mimir-distributed` Helm chart is the best way to install Mimir on Kubernetes.

The highlights that follow include the top features, enhancements, and bugfixes in this release. For a comprehensive list of changes, see the [Helm chart changelog](https://github.com/grafana/mimir/tree/main/operations/helm/charts/mimir-distributed/CHANGELOG.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "bug fixes" rather than "bugfixes" (my browser dictionary doesn't think "bugfix" is a word.

Comment on lines +18 to +22
- Relaxed the hash ring heartbeat period and timeout for distributor, ingester, store-gateway and compactor. This means a reduced load in intra component communication with the tradeoff that abrupt component failures will take longer to detect. The new values are taken from Grafana Cloud Metrics operations.
- The timeout for writing recording rule results has been increased to 10 seconds to accommodate large result sets.
- The distributor termination grace period was increased from 60s to 100s to give more time for a clean termination.
- The read timeout for chunks and index caches using memcached has been increased to `750ms` from `450ms` due to measurements.
- For the distributor and query-frontend components the GRPC maximum connection age and the component shutdown delay has been tuned to avoid invoking components that are shutting down.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these list items parallel (https://developers.google.com/style/lists#parallel-syntax) and also make this list parallel with the later one.

I've tried to include the changes that are also in #7834 but I may have made a mistake.

- Relaxed the hash ring heartbeat period and timeout for distributor, ingester, store-gateway, and compactor.
  This reduces load in intra component communication with the tradeoff that abrupt component failures take longer to detect.
  The new values are taken from Grafana Cloud Metrics operations.
- Increased the timeout for writing recording rule results to `10s` to accommodate large result sets.
- Increased the distributor termination grace period from `60s` to `100s` to give more time for a clean termination.
- Increased the read timeout for chunks and index caches using Memcached from `450ms` to `750ms` based upon operational measurements.
- Tuned the GRPC maximum connection age and shutdown delay for the distributor and query-frontend components avoid invoking components that are shutting down.

krajorama added a commit that referenced this pull request Apr 9, 2024
From suggestions on #7818

Signed-off-by: György Krajcsovits <[email protected]>
krajorama added a commit that referenced this pull request Apr 9, 2024
From suggestions on #7818

Signed-off-by: György Krajcsovits <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants