Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote ruler reads networking dashboard #7751

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Mar 29, 2024

What this PR does

We're missing a dashboard to look "remote ruler reads networking", so in this PR I'm adding one. It's like "Reads networking" but for "Remote ruler".

Dashboard screenshot available here.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pracucci pracucci marked this pull request as ready for review March 29, 2024 09:55
@pracucci pracucci requested review from jdbaldry and a team as code owners March 29, 2024 09:55
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done.

@@ -62,6 +62,7 @@
write: ['distributor', 'ingester', 'mimir_write'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you update the comment for this to indicate that components might belong to more than one group?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 839d125

pracucci added 3 commits April 2, 2024 09:22
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci force-pushed the add-remote-ruler-reads-networking-dashboard branch from ad9cfd4 to 839d125 Compare April 2, 2024 07:26
@pracucci pracucci enabled auto-merge (squash) April 2, 2024 07:27
@pracucci pracucci merged commit cf1d7a8 into main Apr 2, 2024
31 checks passed
@pracucci pracucci deleted the add-remote-ruler-reads-networking-dashboard branch April 2, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants