Add guard against missing samples in KEDA queries #7691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds clauses to some of our KEDA queries to guard against scenarios that could cause unintended scaledowns. This happens when the prometheus targeted by KEDA is down or unresponsive for some time, which could cause data that is used in KEDA queries to be missed. Without this data, when prometheus comes back up, these queries return lower averages for a while, which can cause unintended scaledowns.
An example of what this looks like from kubectl before, during, and after prometheus going down:
With this change, bringing prometheus down for some time and then back up does not result in an unintended scaledown:
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.