-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store-gateway: use bucket index instead of scanning the bucket #6808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe one debug logging option left by mistake?
This is a follow-up to 6673, similar change to 6779 Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
…eChunks Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
…yInTheRing Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
5c7381b
to
6b8f00f
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6808-to-r266 origin/r266
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1a459bb5efeec997ea21fc2a4442c6470dd20e9f
# Push it to GitHub
git push --set-upstream origin backport-6808-to-r266
git switch main
# Remove the local backport branch
git branch -D backport-6808-to-r266 Then, create a pull request where the |
* store-gateway: use bucket index instead of scanning the bucket This is a follow-up to 6673, similar change to 6779 Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncWithDefaultShardingEnabled Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_SyncBlocks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSyncShouldRetryOnFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSync Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_Series_ShouldCorrectlyQuerySeriesSpanningMultipleChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_deleteLocalFilesForExcludedTenants Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SyncShouldKeepPreviousBlocksIfInstanceIsUnhealthyInTheRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SeriesQueryingShouldEnforceMaxChunksPerQueryLimit Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix read-write mode integration tests Signed-off-by: Dimitar Dimitrov <[email protected]> * Clean up users in integration tests more often Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestGettingStartedWithGossipedRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix Test_MaxSeriesAndChunksPerQueryLimitHit Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove debug option Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit 1a459bb)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6808-to-r266 origin/r266
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1a459bb5efeec997ea21fc2a4442c6470dd20e9f
# Push it to GitHub
git push --set-upstream origin backport-6808-to-r266
git switch main
# Remove the local backport branch
git branch -D backport-6808-to-r266 Then, create a pull request where the |
* store-gateway: use bucket index instead of scanning the bucket This is a follow-up to 6673, similar change to 6779 Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncWithDefaultShardingEnabled Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_SyncBlocks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSyncShouldRetryOnFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSync Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_Series_ShouldCorrectlyQuerySeriesSpanningMultipleChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_deleteLocalFilesForExcludedTenants Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SyncShouldKeepPreviousBlocksIfInstanceIsUnhealthyInTheRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SeriesQueryingShouldEnforceMaxChunksPerQueryLimit Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix read-write mode integration tests Signed-off-by: Dimitar Dimitrov <[email protected]> * Clean up users in integration tests more often Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestGettingStartedWithGossipedRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix Test_MaxSeriesAndChunksPerQueryLimitHit Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove debug option Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit 1a459bb)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6808-to-r267 origin/r267
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1a459bb5efeec997ea21fc2a4442c6470dd20e9f
# Push it to GitHub
git push --set-upstream origin backport-6808-to-r267
git switch main
# Remove the local backport branch
git branch -D backport-6808-to-r267 Then, create a pull request where the |
* store-gateway: use bucket index instead of scanning the bucket This is a follow-up to 6673, similar change to 6779 Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncWithDefaultShardingEnabled Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_SyncBlocks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSyncShouldRetryOnFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSync Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_Series_ShouldCorrectlyQuerySeriesSpanningMultipleChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_deleteLocalFilesForExcludedTenants Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SyncShouldKeepPreviousBlocksIfInstanceIsUnhealthyInTheRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SeriesQueryingShouldEnforceMaxChunksPerQueryLimit Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix read-write mode integration tests Signed-off-by: Dimitar Dimitrov <[email protected]> * Clean up users in integration tests more often Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestGettingStartedWithGossipedRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix Test_MaxSeriesAndChunksPerQueryLimitHit Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove debug option Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit 1a459bb)
#6839) * store-gateway: use bucket index instead of scanning the bucket This is a follow-up to 6673, similar change to 6779 Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_InitialSyncWithDefaultShardingEnabled Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_SyncBlocks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSyncShouldRetryOnFailure Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_InitialSync Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_Series_ShouldCorrectlyQuerySeriesSpanningMultipleChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestBucketStores_deleteLocalFilesForExcludedTenants Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SyncShouldKeepPreviousBlocksIfInstanceIsUnhealthyInTheRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestStoreGateway_SeriesQueryingShouldEnforceMaxChunksPerQueryLimit Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix read-write mode integration tests Signed-off-by: Dimitar Dimitrov <[email protected]> * Clean up users in integration tests more often Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix TestGettingStartedWithGossipedRing Signed-off-by: Dimitar Dimitrov <[email protected]> * Fix Test_MaxSeriesAndChunksPerQueryLimitHit Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove debug option Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit 1a459bb) Co-authored-by: Dimitar Dimitrov <[email protected]>
This is a follow-up to #6673, similar change to #6779