query scheduler multi dimension queueing data structures #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit tests that rely on deleted helper methods
…w data structures; TODO update tests to reflect new interface boundaries
francoposa
commented
Oct 30, 2023
Comment on lines
+501
to
+503
| //if tenantCount != len(qb.tenantQueues) { | ||
| // return fmt.Errorf("inconsistent number of tenants list and tenant queues") | ||
| //} |
There was a problem hiding this comment.
TODO implement recursive node count on tree queue to enable this check
francoposa
changed the title
* Update mimir-prometheus * Update changelog entry
Signed-off-by: Arve Knudsen <[email protected]>
* chore(deps): update memcached docker tag to v1.6.22 * Update build with regenerated helm tests and docs --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
…in) (#6454) * chore(deps): update helm release grafana-agent-operator to v0.3.8 * Update build with regenerated helm tests and docs --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
* Update dskit. Signed-off-by: Peter Štibraný <[email protected]> * CHANGELOG.md Signed-off-by: Peter Štibraný <[email protected]> * Apply suggestion. Signed-off-by: Peter Štibraný <[email protected]> --------- Signed-off-by: Peter Štibraný <[email protected]>
* Add tracing span to Ruler.getLocalRules() Signed-off-by: Marco Pracucci <[email protected]> * Fixed tests Signed-off-by: Marco Pracucci <[email protected]> * Add nolint rule Signed-off-by: Marco Pracucci <[email protected]> --------- Signed-off-by: Marco Pracucci <[email protected]>
… v5.2.1 (main) (#6456) * chore(deps): update registry.k8s.io/kustomize/kustomize docker tag to v5.2.1 * Update build image version to pr6456-fb5d96e52f --------- Signed-off-by: Arve Knudsen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…nse (#6522) Signed-off-by: Yuri Nikolic <[email protected]>
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6519-fb5d96e52f`. This can take up to 1 hour. |
francoposa
deleted the
francoposa/query-scheduler-multi-dimension-queueing-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]