Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: quote checksum/config when using external config #6407

Merged
merged 2 commits into from
Oct 19, 2023
Merged

helm: quote checksum/config when using external config #6407

merged 2 commits into from
Oct 19, 2023

Conversation

dimitarvdimitrov
Copy link
Contributor

Fixes #2296

@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner October 17, 2023 11:13
@dimitarvdimitrov
Add CHANGELOG.md
28ee4b5 
Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov mentioned this pull request Oct 17, 2023
Closed
ying-jeanne
ying-jeanne approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimitarvdimitrov dimitarvdimitrov merged commit fe7cd34 into main Oct 19, 2023
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/helm/quote-externalConfigVersion branch October 19, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ying-jeanne ying-jeanne ying-jeanne approved these changes

@lamida lamida lamida approved these changes

Assignees
No one assigned
Labels
helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: mimir-distributed value externalConfigVersion must be quoted when rendered
3 participants
@dimitarvdimitrov @lamida @ying-jeanne