Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add auto approval/merge for helm weekly release #10254

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Dec 16, 2024

What this PR does

Add auto approval/merge for helm weekly release, the condition for auto-approval/merge is

  • the PR is raised by grafana-bot
  • the branch name contains helm-chart-weekly-

Since we already switched to renovate and no dependabot enabled anymore on Mimir, remove the out dated automerge logic on dependabot PR and repurpose it to helm chart weekly auto approval/merge

Example PR that we would like to auto-approval/merge #10253

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • [na] Tests updated.
  • [na] Documentation added.
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na ] about-versioning.md updated with experimental features.

@ying-jeanne ying-jeanne force-pushed the grafanabot branch 2 times, most recently from 068d1bd to 394bb33 Compare December 16, 2024 11:38
@ying-jeanne ying-jeanne marked this pull request as ready for review December 16, 2024 13:51
@ying-jeanne ying-jeanne requested a review from a team as a code owner December 16, 2024 13:51
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks!

@ying-jeanne ying-jeanne merged commit ddb0f58 into main Dec 17, 2024
29 checks passed
@ying-jeanne ying-jeanne deleted the grafanabot branch December 17, 2024 14:01
@narqo
Copy link
Contributor

narqo commented Dec 24, 2024

It seems that it didn't work :/ E.g. #10308

Can not approve your own pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants