Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade google.golang.org/grpc to v1.69.0 #10224

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Dec 12, 2024

What this PR does

TODO:
  • Try using memory pooling when unmarshalling storepb.SeriesResponse in the querier, since it currently leads to huge memory utilization bursts.
  • Try having storepb.SeriesResponse not use LabelAdapter, but instead a type not referencing unmarshalling buffer memory. This should allow us not having to hold on to the unmarshalling buffer for storepb.SeriesResponse.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@aknuds1 aknuds1 force-pushed the arve/upgrade-grpc branch 5 times, most recently from 7f962d6 to 5fb5473 Compare December 13, 2024 07:54
@aknuds1 aknuds1 changed the title WIP: Upgrade google.golang.org/grpc to v1.68.1 WIP: Upgrade google.golang.org/grpc to v1.69.0 Dec 13, 2024
@aknuds1 aknuds1 force-pushed the arve/upgrade-grpc branch 3 times, most recently from 321bc61 to 6be7edd Compare December 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant