Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE: Add support for histogram_stdvar #10211

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Dec 11, 2024

What this PR does

Which issue(s) this PR fixes or relates to

#10067

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner December 11, 2024 06:07
@jhesketh jhesketh mentioned this pull request Dec 11, 2024
@jhesketh jhesketh enabled auto-merge (squash) December 11, 2024 07:05
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo question about comment

Comment on lines +93 to +94
// returns either the standard deviation, or standard variance of a native histogram.
// Float values are ignored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment in the right place? Looks like it should be the docstring for HistogramStdDevStdVar.

@jhesketh jhesketh merged commit 12f4237 into grafana:main Dec 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants