Ops: Also set server.grpc-max-send-msg-size-bytes on ruler-queriers #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
force-pushed
the
jhesketh/grpc-max-msg-size
branch
from
94ce4c5 to
25dd28e
Compare
jhesketh
changed the title
charleskorn
reviewed
Dec 11, 2024
This should match what the ruler-query-frontend is configured for.
jhesketh
force-pushed
the
jhesketh/grpc-max-msg-size
branch
from
25dd28e to
c9c5663
Compare
charleskorn
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
should we see a change in this file for the ruler-querier deployment too with the querier.frontend-client.grpc-max-send-msg-size flag?
There was a problem hiding this comment.
That's already set to the 104857600 value. I'm not sure where tbh.
jhesketh
added a commit
to jhesketh/mimir
that referenced
this pull request
Dec 11, 2024
…eriers (grafana#10208)" This reverts commit d84dccb.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should match what the ruler-query-frontend is configured for.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.