Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE: Add support for histogram_stddev function #10139

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Dec 5, 2024

What this PR does

Which issue(s) this PR fixes or relates to

#10067

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner December 5, 2024 10:31
@jhesketh jhesketh mentioned this pull request Dec 5, 2024
@jhesketh jhesketh enabled auto-merge (squash) December 5, 2024 10:35
@jhesketh jhesketh force-pushed the jhesketh/mqe-histogram-stddev branch from f476600 to e28a520 Compare December 5, 2024 11:05
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches upstream, matches tests.
Look(!) ok from MQE point of view but I'm no expert.

@jhesketh jhesketh merged commit 2f46b6f into grafana:main Dec 10, 2024
29 checks passed
@jhesketh jhesketh deleted the jhesketh/mqe-histogram-stddev branch December 10, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants