Skip to content

Commit

Permalink
kafka replay speed: update fetch bytes estimation on multiple attempts (
Browse files Browse the repository at this point in the history
#9493) (#9509)

Without this we end up using a bad estimation for the whole fetch

Signed-off-by: Dimitar Dimitrov <[email protected]>
(cherry picked from commit 6a998f6)

Co-authored-by: Dimitar Dimitrov <[email protected]>
  • Loading branch information
grafanabot and dimitarvdimitrov authored Oct 3, 2024
1 parent a47f97d commit f39c3bd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/storage/ingest/fetcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ func (r *concurrentFetchers) run(ctx context.Context, wants chan fetchWant, logg
}
// Next attempt will be from the last record onwards.
w.startOffset = f.Records[len(f.Records)-1].Offset + 1
w = w.UpdateBytesPerRecord(f.fetchedBytes, len(f.Records)) // This takes into account the previousFetch too. This should give us a better average than using just the records from the last attempt.

// We reset the backoff if we received any records whatsoever. A received record means _some_ success.
// We don't want to slow down until we hit a larger error.
Expand Down

0 comments on commit f39c3bd

Please sign in to comment.