Skip to content

Commit

Permalink
Jsonnet: add config option for querier-only CLI flags (#9503)
Browse files Browse the repository at this point in the history
* Jsonnet: add config option for querier-only CLI flags

* Add changelog entry
  • Loading branch information
charleskorn authored Oct 3, 2024
1 parent 8004bb6 commit 6d02c17
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
* [ENHANCEMENT] Add `ingest_storage_ingester_autoscaling_triggers` option to specify multiple triggers in ScaledObject created for ingest-store ingester autoscaling. #9422
* [ENHANCEMENT] Add `ingest_storage_ingester_autoscaling_scale_up_stabilization_window_seconds` and `ingest_storage_ingester_autoscaling_scale_down_stabilization_window_seconds` config options to make stabilization window for ingester autoscaling when using ingest-storage configurable. #9445
* [ENHANCEMENT] Make label-selector in ReplicaTemplate/ingester-zone-a object configurable when using ingest-storage. #9480
* [ENHANCEMENT] Add `querier_only_args` option to specify CLI flags that apply only to queriers but not ruler-queriers. #9503

### Mimirtool

Expand Down
7 changes: 6 additions & 1 deletion operations/mimir/querier.libsonnet
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
local container = $.core.v1.container,

// CLI flags for queriers. Also applied to ruler-queriers.
querier_args::
$._config.commonConfig +
$._config.usageStatsConfig +
Expand Down Expand Up @@ -29,6 +30,10 @@
'mem-ballast-size-bytes': 1 << 28, // 256M
},

// CLI flags that are applied only to queriers, and not ruler-queriers.
// Values take precedence over querier_args.
querier_only_args:: {},

querier_ports:: $.util.defaultPorts,

newQuerierContainer(name, args, envmap={})::
Expand Down Expand Up @@ -58,7 +63,7 @@
querier_node_affinity_matchers:: [],

querier_container::
self.newQuerierContainer('querier', $.querier_args, $.querier_env_map),
self.newQuerierContainer('querier', $.querier_args + $.querier_only_args, $.querier_env_map),

newQuerierDeployment(name, container, nodeAffinityMatchers=[])::
local deployment = $.apps.v1.deployment;
Expand Down

0 comments on commit 6d02c17

Please sign in to comment.