Remove "track_sizes" option from Memcached in jsonnet and helm

The option tracks the size of items in the cache in a histogram. We don't use this information for anything or monitor it in any way so remove it. Signed-off-by: Nick Pillitteri <[email protected]>
grafana · Nov 27, 2024 · 3b9df53 · 3b9df53
1 parent 73d2bdd
commit 3b9df53
Show file tree

Hide file tree

Showing 104 changed files with 28 additions and 332 deletions.
diff --git a/operations/helm/charts/mimir-distributed/templates/memcached/_memcached-statefulset.tpl b/operations/helm/charts/mimir-distributed/templates/memcached/_memcached-statefulset.tpl
@@ -105,7 +105,7 @@ spec:
               name: client
           args:
             - -m {{ .allocatedMemory }}
-            - --extended=modern,track_sizes{{ with .extraExtendedOptions }},{{ . }}{{ end }}
+            - --extended=modern{{ with .extraExtendedOptions }},{{ . }}{{ end }}
             - -I {{ .maxItemMemory }}m
             - -c {{ .connectionLimit }}
             - -v

diff --git a/...s-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...s-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -63,7 +63,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...tps-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/...tps-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -63,7 +63,7 @@ spec:
               name: client
           args:
             - -m 2048
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -63,7 +63,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -63,7 +63,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...tes/graphite-proxy/graphite-aggregation-cache/graphite-aggregation-cache-statefulset.yaml b/...tes/graphite-proxy/graphite-aggregation-cache/graphite-aggregation-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...tes/graphite-proxy/graphite-metric-name-cache/graphite-metric-name-cache-statefulset.yaml b/...tes/graphite-proxy/graphite-metric-name-cache/graphite-metric-name-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...e-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...e-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...rge-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/...rge-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 2048
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 1024
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...l-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...l-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...all-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/...all-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 2048
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...map-values-generated/mimir-distributed/templates/admin-cache/admin-cache-statefulset.yaml b/...map-values-generated/mimir-distributed/templates/admin-cache/admin-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 64
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...p-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...p-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...map-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/...map-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 2048
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...5-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...5-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 8192
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/....25-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/....25-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 2048
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -60,7 +60,7 @@ spec:
               name: client
           args:
             - -m 512
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...s-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml b/...s-values-generated/mimir-distributed/templates/chunks-cache/chunks-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 10
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...oss-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml b/...oss-values-generated/mimir-distributed/templates/index-cache/index-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 30
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml b/...lues-generated/mimir-distributed/templates/metadata-cache/metadata-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 10
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 1m
             - -c 16384
             - -v

diff --git a/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml b/...values-generated/mimir-distributed/templates/results-cache/results-cache-statefulset.yaml
@@ -58,7 +58,7 @@ spec:
               name: client
           args:
             - -m 10
-            - --extended=modern,track_sizes
+            - --extended=modern
             - -I 5m
             - -c 16384
             - -v

diff --git a/operations/mimir-tests/test-all-components-generated.yaml b/operations/mimir-tests/test-all-components-generated.yaml
@@ -1243,7 +1243,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1297,7 +1296,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1351,7 +1349,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1405,7 +1402,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached

diff --git a/operations/mimir-tests/test-all-components-with-custom-max-skew-generated.yaml b/operations/mimir-tests/test-all-components-with-custom-max-skew-generated.yaml
@@ -1243,7 +1243,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1297,7 +1296,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1351,7 +1349,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1405,7 +1402,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached

diff --git a/operations/mimir-tests/test-all-components-with-custom-runtime-config-generated.yaml b/operations/mimir-tests/test-all-components-with-custom-runtime-config-generated.yaml
@@ -1252,7 +1252,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1306,7 +1305,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1360,7 +1358,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1414,7 +1411,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached

diff --git a/operations/mimir-tests/test-all-components-with-tsdb-head-early-compaction-generated.yaml b/operations/mimir-tests/test-all-components-with-tsdb-head-early-compaction-generated.yaml
@@ -1245,7 +1245,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1299,7 +1298,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1353,7 +1351,6 @@ spec:
         - -I 5m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
@@ -1407,7 +1404,6 @@ spec:
         - -I 1m
         - -c 16384
         - -v
-        - --extended=track_sizes
         image: memcached:1.6.28-alpine
         imagePullPolicy: IfNotPresent
         name: memcached
-Original file line number
+Diff line change
@@ Expand Up / @@ -63,7 +63,7 @@ spec: @@
                   name: client
               args:
                 - -m 8192
-                - --extended=modern,track_sizes
+                - --extended=modern
                 - -I 1m
                 - -c 16384
                 - -v
@@ Expand Down @@