Ensure we don't leak any goroutines.

Signed-off-by: gotjosh <[email protected]>
grafana · Sep 26, 2024 · 23f182a · 23f182a
1 parent 553dbd5
commit 23f182a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/storage/ingest/reader.go b/pkg/storage/ingest/reader.go
@@ -1269,6 +1269,9 @@ func (r *concurrentFetchers) start(ctx context.Context, startOffset int64, concu
 	)
 	nextFetch.bytesPerRecord = 10_000 // start with an estimation, we will update it as we consume
 
+	// We need to make sure we don't leak any goroutine given that start is called within a goroutine.
+	r.wg.Add(1)
+	defer r.wg.Done()
 	for {
 		refillBufferedResult := nextResult
 		if readyBufferedResults != nil {