Skip to content

Commit

Permalink
Apply reviewer feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Arve Knudsen <[email protected]>
  • Loading branch information
aknuds1 committed Dec 12, 2024
1 parent 9047e5c commit 0d9f008
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ To publish a stable release:
1. Update Jsonnet tests: `make build-jsonnet-tests`
1. Commit updated tests
1. Update dashboard screenshots
1. Make sure that operations/mimir-mixin-tools/screenshots/.config is configured with a Mimir dev cell/tenant
1. Make sure that operations/mimir-mixin-tools/screenshots/.config is configured according to the directions in [operations/mimir-mixin-tools/screenshots/run.sh](https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-tools/screenshots/run.sh)
1. Make sure that operations/mimir-mixin-tools/serve/.config is configured according to the directions in [operations/mimir-mixin-tools/serve/run.sh](https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-tools/serve/run.sh)
1. Run `make mixin-screenshots`
1. Review all updated screenshots and ensure no sensitive data is disclosed
1. Open a PR
Expand Down

0 comments on commit 0d9f008

Please sign in to comment.