Merge pull request #41 from loadimpact/fix/less-strict-cookie-validation

[fix] make cookie validation less strict.
grafana · Jun 5, 2020 · e6ea4ca · e6ea4ca
2 parents 2c6b0c4 + 461d733
commit e6ea4ca
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 17 deletions.
diff --git a/src/validate/cookie.js b/src/validate/cookie.js
@@ -17,6 +17,7 @@ function cookie(node, i, j, assay) {
   name(node.name, i, assay)
 }
 
+// eslint-disable-next-line no-unused-vars
 function validate(node, i, j, assay) {
   if (empty(node.name)) {
     throw new InvalidArchiveError({ name: 'MissingCookieName' }, `Missing cookie name (${i}:${j})`)
@@ -27,12 +28,6 @@ function validate(node, i, j, assay) {
       `Invalid cookie name (${i}:${j}): must be string`
     )
   }
-  if (assay.requestCookieNames.has(i) && assay.requestCookieNames.get(i).has(node.name)) {
-    throw new InvalidArchiveError(
-      { name: 'DuplicateCookieName' },
-      `Duplicate cookie name (${i}:${j}): ${node.name}`
-    )
-  }
   if (node.value && typeof node.value !== 'string') {
     throw new InvalidArchiveError(
       { name: 'InvalidCookieValue' },

diff --git a/test/unit/validate/cookie.js b/test/unit/validate/cookie.js
@@ -20,17 +20,6 @@ test('invalid name', (t) => {
   )
 })
 
-test('duplicate name', (t) => {
-  const assay = makeAssay()
-  cookie({ name: 'session' }, 8, 0, assay)
-  t.throws(
-    () => {
-      cookie({ name: 'session' }, 8, 1, assay)
-    },
-    { name: 'DuplicateCookieName' }
-  )
-})
-
 test('invalid value', (t) => {
   t.throws(
     () => {